Fix flaky unit test - Githubissues

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes

https://www.medik8s.io/

Apache License 2.0

45 stars 17 forks source link

Fix flaky unit test #208

Closed slintes closed 4 months ago

slintes commented 4 months ago

Why we need this PR

The "DS Recreation on Operator Update" unit tests are flaky, they fail to create the ds sometimes because it already exists. Reason that the outer JustBeforeEach runs first, which creates the SNR config, which async triggers creation of a ds. That conflicts with the creation of ds in the inner JustBeforeEach.

Changes made

Move creation of the initial ds from JustBeforeEach to BeforeEach, so it runs before the outer JustBeforeEach.
Improve cleanup by ensuring the ds is always deleted

openshift-ci[bot] commented 4 months ago

@slintes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.15-openshift-e2e	dd78a20891f724822f5e31c95bf71df8e204e630	link	true	`/test 4.15-openshift-e2e`
ci/prow/4.14-openshift-e2e	dd78a20891f724822f5e31c95bf71df8e204e630	link	true	`/test 4.14-openshift-e2e`
ci/prow/4.16-openshift-e2e	dd78a20891f724822f5e31c95bf71df8e204e630	link	true	`/test 4.16-openshift-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

slintes commented 4 months ago

/approve

slintes commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

slintes commented 4 months ago

seems we go on with #204 🤷🏼‍♂️

/close

openshift-ci[bot] commented 4 months ago

@slintes: Closed this PR.

In response to [this](https://github.com/medik8s/self-node-remediation/pull/208#issuecomment-2169500271): >seems we go on with #204 🤷🏼‍♂️ > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.