Handle unexpected use case where SNR's configuration is deleted

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes

https://www.medik8s.io/

Apache License 2.0

45 stars 17 forks source link

Handle unexpected use case where SNR's configuration is deleted #209

Closed mshitrit closed 4 months ago

mshitrit commented 4 months ago

Why we need this PR

SNR should have only one default configuration, since the configuration affects the SNR agents which are running on each node (and every node has one agent). Deleting this configuration will prevent the operator working properly, since preventing deletion of the configuration is problematic (for example it'll prevents OLM cleanup) we're making sure that SNR is properly disabled when the configuration is deleted.

Changes made

Issue a webhook warning when the configuration is deleted
Stop outstanding remediation while there is no configuration and set Disabled status on the remediation
Remove the disabled status form the remediation when the configuration is created in order to re-trigger the remediation

Which issue(s) this PR fixes

ECOPROJECT-1996

Test plan

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

slintes commented 4 months ago

/hold

see my comments on the issue

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.14-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

Something is wrong with this PR. It contains commits and modified code of changes which are in main already... :/

I might have messed it up when handling the merge conflicts, hopefully fine now.

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/test 4.15-openshift-e2e

slintes commented 4 months ago

/hold

not sure if other threads are resolved

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

clobrano commented 4 months ago

My observations have been addressed. Lgtm too

mshitrit commented 4 months ago

/retest

mshitrit commented 4 months ago

/retest