Closed mshitrit closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/hold
see my comments on the issue
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/test 4.14-openshift-e2e
/test 4.15-openshift-e2e
Something is wrong with this PR. It contains commits and modified code of changes which are in main already... :/
I might have messed it up when handling the merge conflicts, hopefully fine now.
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/hold
not sure if other threads are resolved
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano, mshitrit
The full list of commands accepted by this bot can be found here.
The pull request process is described here
My observations have been addressed. Lgtm too
/retest
/retest
Why we need this PR
SNR should have only one default configuration, since the configuration affects the SNR agents which are running on each node (and every node has one agent). Deleting this configuration will prevent the operator working properly, since preventing deletion of the configuration is problematic (for example it'll prevents OLM cleanup) we're making sure that SNR is properly disabled when the configuration is deleted.
Changes made
Which issue(s) this PR fixes
ECOPROJECT-1996
Test plan