search

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes
https://www.medik8s.io/
Apache License 2.0
45 stars 17 forks source link

Cleanup #211

Closed slintes closed 4 months ago

slintes commented 4 months ago

Why we need this PR

Cleanup needed

Changes made

Remove unused code, fix outdated name, fix ConfigInitializer

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 4 months ago

known flaky test / cluster setup failure 🤷🏼‍♂️ /override ci/prow/4.14-openshift-e2e /override ci/prow/4.15-openshift-e2e

openshift-ci[bot] commented 4 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.14-openshift-e2e, ci/prow/4.15-openshift-e2e

In response to [this](https://github.com/medik8s/self-node-remediation/pull/211#issuecomment-2160823344): >known flaky test / cluster setup failure 🤷🏼‍♂️ >/override ci/prow/4.14-openshift-e2e >/override ci/prow/4.15-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
slintes commented 4 months ago

same story /override ci/prow/4.13-openshift-e2e /override ci/prow/4.16-openshift-e2e

openshift-ci[bot] commented 4 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.13-openshift-e2e, ci/prow/4.16-openshift-e2e

In response to [this](https://github.com/medik8s/self-node-remediation/pull/211#issuecomment-2160876644): >same story >/override ci/prow/4.13-openshift-e2e >/override ci/prow/4.16-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.