search

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes
https://www.medik8s.io/
Apache License 2.0
45 stars 17 forks source link

Increase timeout on deleteAndWait in e2e #216

Closed slintes closed 4 months ago

slintes commented 4 months ago

Why we need this PR

Flaky e2e

Changes made

Increase timeout on deleteAndWait in e2e. This used for deleting SNR CRs, which only works when remediation is done, which can take longer than 2 min.

slintes commented 4 months ago

/approve cancel

slintes commented 4 months ago

/approve

slintes commented 4 months ago

/retest

slintes commented 4 months ago

/approve

slintes commented 4 months ago

/retest

slintes commented 4 months ago

/approve

slintes commented 4 months ago

/approve

slintes commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@slintes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-openshift-e2e 2213028dfb8215dedc274d8c0ceefdf0fb484b3e link true /test 4.16-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slintes commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 4 months ago

/test ci/prow/4.15-test

openshift-ci[bot] commented 4 months ago

@slintes: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/self-node-remediation/pull/216#issuecomment-2164748991): >/test ci/prow/4.15-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
slintes commented 4 months ago

/test 4.15-test

slintes commented 4 months ago

failed test is known issue, will merge this because it reduces flakiness of e2e