medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes
https://www.medik8s.io/
Apache License 2.0
45 stars 17 forks source link

Small improvement in Readme #218

Closed slintes closed 4 months ago

slintes commented 4 months ago

Why we need this PR

Changes made

Improved wording for NHC

slintes commented 4 months ago

not needed for doc only changes

/override ci/prow/4.12-openshift-e2e /override ci/prow/4.12-test /override ci/prow/4.13-openshift-e2e /override ci/prow/4.13-test /override ci/prow/4.14-openshift-e2e /override ci/prow/4.14-test /override ci/prow/4.15-openshift-e2e /override ci/prow/4.15-test

openshift-ci[bot] commented 4 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.12-openshift-e2e, ci/prow/4.12-test, ci/prow/4.13-openshift-e2e, ci/prow/4.13-test, ci/prow/4.14-openshift-e2e, ci/prow/4.14-test, ci/prow/4.15-openshift-e2e, ci/prow/4.15-test

In response to [this](https://github.com/medik8s/self-node-remediation/pull/218#issuecomment-2162388368): >not needed for doc only changes > >/override ci/prow/4.12-openshift-e2e >/override ci/prow/4.12-test >/override ci/prow/4.13-openshift-e2e >/override ci/prow/4.13-test >/override ci/prow/4.14-openshift-e2e >/override ci/prow/4.14-test >/override ci/prow/4.15-openshift-e2e >/override ci/prow/4.15-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
slintes commented 4 months ago

/approve

slintes commented 4 months ago

/retest

slintes commented 4 months ago

/override ci/prow/4.16-openshift-e2e /override ci/prow/4.16-test /override ci/prow/4.17-openshift-e2e /override ci/prow/4.17-test

openshift-ci[bot] commented 4 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.16-openshift-e2e, ci/prow/4.16-test, ci/prow/4.17-openshift-e2e, ci/prow/4.17-test

In response to [this](https://github.com/medik8s/self-node-remediation/pull/218#issuecomment-2199695496): >/override ci/prow/4.16-openshift-e2e >/override ci/prow/4.16-test >/override ci/prow/4.17-openshift-e2e >/override ci/prow/4.17-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
slintes commented 4 months ago

/approve cancel

slintes commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment