search

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes
https://www.medik8s.io/
Apache License 2.0
45 stars 17 forks source link

Remove unused variable `isSkipCleanup` #224

Closed mshitrit closed 3 months ago

mshitrit commented 3 months ago

Why we need this PR

This variable was used in an early stage of #204, the final merged version of that PR didn't use this variable making it redundant, so it should be removed.

Changes made

removing unused variable

Which issue(s) this PR fixes

Technical debt

Test plan

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 3 months ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mshitrit commented 3 months ago

/retest