Some fixes and e2e test improvements

slintes commented 3 months ago

re-enable and fix api check log tests in e2e test - use service IP for killing API connection - kill API connection on SNR DS pod - add peer check server logs and use them for test which can't get logs from unhealthy node's SNR agent pod - wait for pod deletion only, not restart (restart is caused by reboot, not SNR)
refactor / cleanup e2e tests
fix owner / node name / machine name check in peer check server and agent reconciler
update sort-imports, which ignores generated files now

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

slintes commented 3 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mshitrit commented 3 months ago

/unhold

slintes commented 3 months ago

strange error for ds pod creation in 4.13:

"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory"

since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220

/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.9

openshift-cherrypick-robot commented 3 months ago

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to [this](https://github.com/medik8s/self-node-remediation/pull/226#issuecomment-2218325662): >strange error for ds pod creation in 4.13: >``` >"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory" >``` > >since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220 > >/override ci/prow/4.13-openshift-e2e > >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 3 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.13-openshift-e2e

In response to [this](https://github.com/medik8s/self-node-remediation/pull/226#issuecomment-2218325662): >strange error for ds pod creation in 4.13: >``` >"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory" >``` > >since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220 > >/override ci/prow/4.13-openshift-e2e > >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-cherrypick-robot commented 3 months ago

@slintes: new pull request created: #233

In response to [this](https://github.com/medik8s/self-node-remediation/pull/226#issuecomment-2218325662): >strange error for ds pod creation in 4.13: >``` >"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory" >``` > >since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220 > >/override ci/prow/4.13-openshift-e2e > >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

medik8s / self-node-remediation

Some fixes and e2e test improvements #226