Open novasbc opened 3 weeks ago
/test 4.15-openshift-e2e
Hi @novasbc. Thanks for your PR.
I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@novasbc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
Hi, do you mind extending the description please? What's the issue, how do you fix it, how do you test the changes... Also, please check the failed test. Thanks
Hi, do you mind extending the description please? What's the issue, how do you fix it, how do you test the changes... Also, please check the failed test. Thanks
@slintes I updated the description, included the issue # as well.
Also, fixed the build which was failing with 'make verify-bundle', because the bundle hadn't been updated.
Thanks!
/test 4.16-openshift-e2e
fixed an issue which was causing a failure with make test, regarding rebooter being nil
/test 4.15-openshift-e2e
/test 4.16-openshift-e2e
/test 4.15-openshift-e2e
/test 4.13-openshift-e2e
/test 4.13-openshift-e2e
@razo7 @mshitrit
I looked into the e2e failures reported over the past few days and realized that it was due to temporary/environmental issues. When I re-ran they started passing better. We can't run the tests in an openshift environment, so weren't seeing the same things locally.
Anyhow, I believe this is ready for review.
Thanks!
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: novasbc Once this PR has been reviewed and has the lgtm label, please ask for approval from clobrano. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Why we need this PR
Existing code requires there to be at least one other peer worker node before remediation can occur, precluding SNR from remediating on a configuration with 3 control plane nodes + 1 worker node, which is a scenario that we support for bare minimum deployments.
Changes made
Which issue(s) this PR fixes
Fixes #213
Test plan