Closed ralphtheninja closed 9 years ago
Thanks, I'm happy to take it, but can you merge it with master and assure that it passes Travis build?
Sure but what's going on here? These are just example scripts. Why would they have anything to do with travis?
@ralphtheninja there's a linter bound to travis, and all files in a project should confirm to defined lint rules (eventual errors that can be picked via static analysis, whitespace conventions etc)
Ok. I first thought that tad tried running corresponding test files from the examples folder. Let me try again.
@ralphtheninja yes, that was the case, but that should be fixed once you assure you're up to date with master
.. and be sure to reinstall dependencies after update
Done.
Oh, I have to run the linter locally. Sorry, adjusting :)
Ok :) You can try: "npm run lint-console", you'll have live overview
Got most fixed but have problems finding out what Unexpected '(space)'
means:
Cool feature btw npm run lint-console
!
@ralphtheninja it's probably because indentation is done with spaces while it should be with tabs
There we go.
Thank you!
I extracted some of the code from the
README
so you can run examples quick rather than having to copy paste etc.