medikoo / cli-color

Colors and formatting for the console
ISC License
676 stars 34 forks source link

add examples from readme #25

Closed ralphtheninja closed 9 years ago

ralphtheninja commented 9 years ago

I extracted some of the code from the README so you can run examples quick rather than having to copy paste etc.

medikoo commented 9 years ago

Thanks, I'm happy to take it, but can you merge it with master and assure that it passes Travis build?

ralphtheninja commented 9 years ago

Sure but what's going on here? These are just example scripts. Why would they have anything to do with travis?

medikoo commented 9 years ago

@ralphtheninja there's a linter bound to travis, and all files in a project should confirm to defined lint rules (eventual errors that can be picked via static analysis, whitespace conventions etc)

ralphtheninja commented 9 years ago

Ok. I first thought that tad tried running corresponding test files from the examples folder. Let me try again.

medikoo commented 9 years ago

@ralphtheninja yes, that was the case, but that should be fixed once you assure you're up to date with master

medikoo commented 9 years ago

.. and be sure to reinstall dependencies after update

ralphtheninja commented 9 years ago

Done.

ralphtheninja commented 9 years ago

Oh, I have to run the linter locally. Sorry, adjusting :)

medikoo commented 9 years ago

Ok :) You can try: "npm run lint-console", you'll have live overview

ralphtheninja commented 9 years ago

Got most fixed but have problems finding out what Unexpected '(space)' means:

unexpected-space

ralphtheninja commented 9 years ago

Cool feature btw npm run lint-console!

medikoo commented 9 years ago

@ralphtheninja it's probably because indentation is done with spaces while it should be with tabs

ralphtheninja commented 9 years ago

There we go.

medikoo commented 9 years ago

Thank you!