medikoo / es5-ext

ECMAScript extensions (with respect to upcoming ECMAScript features)
ISC License
168 stars 81 forks source link

Resolve cross dependency #51

Closed martinheidegger closed 7 years ago

martinheidegger commented 7 years ago

es5-ext is requiring a dependency on es6-iterator and es6-iterator is requiring a dependency on es5-ext. This cross dependency is not cool according to npm that dies in a Maximum call stack size exceeded message when it's trying to shrinkwrap es5-ext (and probably even other cases).

It would be awesome if es5-ext or es6-iterator could be changed to have only a one-way dependency.

martinheidegger commented 7 years ago

Related: https://github.com/npm/npm/issues/13730

medikoo commented 7 years ago

@martinheidegger it's intended and this works perfectly with normal install. It's really a bug of npm shrinkrwap, so let's solve this issue at https://github.com/npm/npm/issues/13730

martinheidegger commented 7 years ago

@medikoo Thank you for answering. Out of curiosity: What is the intention behind it? Even in consultation with dev-friends I couldn't make out why this would make sense. I would be very grateful for enlightenment.

medikoo commented 7 years ago

@martinheidegger sure: