typo in engines.node - Githubissues

medikoo / memoizee

Complete memoize/cache solution for JavaScript

ISC License

1.73k stars 61 forks source link

typo in engines.node #136

Closed perrefe closed 3 months ago

perrefe commented 3 months ago

There is a typo in engine version specification in package.json for v0.4.16 release

"engines": {
    "node": ">=.0.12"
},

error memoizee@0.4.16: The engine "node" is incompatible with this module. Expected version ">=.0.12". Got "20.11.1"
error Found incompatible module.

I'm using yarn v1.22.19 and node 20.11.1

I think it should be "node": ">=12.0"

thanks!

NicoHinderling commented 3 months ago

+1 im also facing this right now

perrefe commented 3 months ago

Using npm 10.5.2 shows this warning

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'memoizee@0.4.16',
npm WARN EBADENGINE   required: { node: '>=.0.12' },
npm WARN EBADENGINE   current: { node: 'v20.13.1', npm: '10.5.2' }
npm WARN EBADENGINE }

pcollaog commented 3 months ago

Blari commented 3 months ago

As a temporary solution until the author fixes the typo, you can add the following to your package.json file:

For yarn install:

"resolutions": {
  "memoizee": "0.4.14"
}

For npm install:

"overrides": {
  "memoizee": "0.4.14"
}

tsuyoda commented 3 months ago

simlu commented 3 months ago

https://github.com/medikoo/memoizee/commit/1a6989ff797e415625db405f3e52094f72aaa5a4

diegodleon commented 3 months ago

galaxyreal commented 3 months ago

Thanks for @Blari 's solution. Additionally, Memoizee 0.4.15 is working as well.

"resolutions": {
  "memoizee": "0.4.15"
}

lynnzc commented 3 months ago

As a temporary solution until the author fixes the typo, you can add the following to your package.json file:

For yarn install:
"resolutions": {
  "memoizee": "0.4.14"
}
For npm install:
"overrides": {
  "memoizee": "0.4.14"
}

this works, 👍