medillcmip / Radregator

A Context Management System
GNU General Public License v3.0
7 stars 1 forks source link

questions on front page storing old data #112

Closed shaneshifflett closed 13 years ago

shaneshifflett commented 13 years ago

Deleted replies still appear as a question on the front page and after they have been deleted they are not removed from this area on the front page, leading to a NaN index and subsequently a django error

ghing commented 13 years ago

It looks like this might be an issue of the delete operation not correctly marking the reply as deleted rather than the code that retrieves the questions for the view.

core.views.frontpage makes a call to _core.views.frontpagequestions to get the questions to display on the front page. This code looks like this:

def frontpage_questions(count=10):
    """Return a list of questions to be displayed on the front page.

    Currently it returns the most recent questions in reverse chronological
    order.

    Keyword arguments:
    count -- Number fo questions to return (default 10)

    """

    questions = Comment.objects.filter(is_deleted=False, \
        comment_type__name="Question").order_by('-date_created')[:count]

    return questions

So it seems like deleted replies should be filtered out.

shaneshifflett commented 13 years ago

looks like it is displaying questions removed from a topic, not deleted comments

shaneshifflett commented 13 years ago

closed with commit 8e9894226780e5241142