search

mediocregopher / goat

A simple, yaml-based go dependency manager
Apache License 2.0
68 stars 11 forks source link

Correct goget to get #25

Closed tummychow closed 10 years ago

tummychow commented 10 years ago

Looks like a typo. The code is actually looking for type: get.

mediocregopher commented 10 years ago

Ugh, can't believe I did that. I'm not sure we shouldn't just change the code to match the docs though. I don't see how anyone would have successfully added a goget dep to their project without just not specifying the type (which is what I always do), in which case there's not any existing .go.yamls that would be broken (that weren't already broken) by fixing the code.

tummychow commented 10 years ago

Hm, that's true. It's the same either way to me; as the maintainer it's your call which change you want to make. I can push up a PR for the code change instead if that makes more sense.

mediocregopher commented 10 years ago

Let's just go ahead and fix the code then. Super simple change :P

tummychow commented 10 years ago

Opened new PR because I'm too lazy to drop into the terminal and overwrite the old one.