add sentinel.NewClientCustom - fixes #19

mstoykov commented 8 years ago

Maybe it will be better if there is redis.Dial for each master name?

Either by map[string]redis.Dial or a func(name string)redis.Dial?

mediocregopher commented 8 years ago

Hi! thanks for the PR! This is definitely something which needs to be added, thanks for submitting it. A couple overall comments, plus some inline ones:

You're definitely going to need to store the dialfunc in the Client struct, because you're going to need it inside spin when a master switch happens and pool.New is called again.
As for having a redis.Dial for each master, that seems rather complex, it would make more sense for someone with that kind of setup to simply make two clients, one for each master. In all honesty I should have made the Client only support one master from the beginning, it would have made the api much cleaner and more inline with the other radix packages (but that's just me rambling).

mstoykov commented 8 years ago

The main reason I store a pool.DialFunc instead of sentinel.DialFunc is because we will have to cast it either way. Line 241 was getting a bit long too :smile:

mediocregopher commented 8 years ago

A couple small things then it's good to merge I think :)

mediocregopher commented 8 years ago

done, thanks for contributing!

mediocregopher / radix.v2

add sentinel.NewClientCustom - fixes #19 #20