search

mediocregopher / radix.v2

Redis client for Go
http://godoc.org/github.com/mediocregopher/radix.v2
MIT License
433 stars 92 forks source link

Export newRespIOErr #38

Closed kixelated closed 8 years ago

kixelated commented 8 years ago

It's otherwise impossible for a 3rd party library to create an IOErr. I'm using this in order to create a custom pool class that will retry if a pooled connection returns an IOErr. Right now it's only possible to return an AppErr (if the dial fails), which makes it harder to distinguish between an actual fatal error.

mediocregopher commented 8 years ago

Hey @kixelated, thanks for the PR. I'm currently out traveling but I'll be sure to check it out once I get back, should be around middle of next week.

mediocregopher commented 8 years ago

Made one small comment, but otherwise looks good, thanks for submitting! :)

mediocregopher commented 8 years ago

I got impatient and went ahead and made that typo fix manually. You're still the author on the commit so you should still get credit as a collaborator in github. Thanks!

kixelated commented 8 years ago

No worries, was just busy this week at work. Thanks!