search

mediocregopher / radix.v2

Redis client for Go
http://godoc.org/github.com/mediocregopher/radix.v2
MIT License
433 stars 92 forks source link

Add Bool() in Resp #56

Closed kondr1 closed 7 years ago

mediocregopher commented 7 years ago

Hey @kondr1, I really appreciate you taking the time to make a PR for radix, but I don't think I'm can accept this one. Redis itself has no boolean type, and what people decide in their application constitutes true or false could vary wildly. For example some might consider empty string to be false-y while all non-empty strings truth-y, and others might say the strings "0" and "false" are also false-y. Making a decision about what's what within the driver I think would cause more confusion than it would clear up.

I'm sorry I couldn't merge this in, please always feel free to submit an issue beforehand to make sure you and the maintainer agree on your approach, and I hope this doesn't discourage you from contributing in the future. Thanks!

kondr1 commented 7 years ago

Ok! It make sense. I was misled that the redis has exist and hexist I'am sorry that i not submit an issue.