search

mediocregopher / radix.v2

Redis client for Go
http://godoc.org/github.com/mediocregopher/radix.v2
MIT License
433 stars 92 forks source link

some suggestions #75

Closed iiinsomnia closed 6 years ago

iiinsomnia commented 6 years ago
iiinsomnia commented 6 years ago

It would be better to add maxOpenConns and maxIdleConns for pool

mediocregopher commented 6 years ago

Hi @IIInsomnia! Thank you for the suggestions. You're right that the connect and write/read timeouts might be better being settable separately. I'm not sure I agree with your suggestions for how the pool can be changed, but at any rate this particular API is pretty set in stone at this point and it'd be difficult to be changed.

If you'd like, you can check out radix.v3 which is basically stable and allows for much greater customization of individual components, so even if you disagree with how I've implemented some part of it you should be able to switch it out with your own implementation fairly simply.