mediumroast / mediumroast_js

Mediumroast for GitHub CLI and API/SDK

https://www.mediumroast.io/product.html

Apache License 2.0

1 stars 0 forks source link

mediumroast_js: logo_server's output isn't showing up correctly in the company object #78

Closed miha42-github closed 10 months ago

miha42-github commented 10 months ago

Introduction

Calling the logo_server should enable the storage of an icon from a company's website. The results aren't coming back correctly. Confirmation should be made that the data is returning correctly and if so then we need to understand why the data isn't coming back in the right format.

Implementation notes

The present implementation relies on an approach that is a layer on top of axios. This may not be optimal as it adds unnecessary complications. The suggestion is to convert into an approach that merely uses axios directly thus simplifying calls to the service.

miha42-github commented 10 months ago

This has been tested with both public and private companies and has been shown to work.