search

medivo / slack-responder

13 stars 12 forks source link

Could simplify this to a Sinatra app and add Docker integration for easy deployment #2

Open codelitt opened 9 years ago

codelitt commented 9 years ago

Your slack-trello gem is good. It easily integrates with Sinatra. Sinatra would be a much cleaner option with a lot less bloat. A Docker setup would allow people to deploy it easily (and contribute). This is a WIP and just a POC: https://github.com/codelittinc/slack-trello

Take a look and let me know what you think.

MrPowers commented 9 years ago

Thanks for creating the Sinatra app! I've never used Sinatra before, but I agree that is probably better suited for this application... Rails seems like overkill. I am going to add a link to your Sinatra app in the README, so people know about your lighter weight option.

I added some new commands to the slack_trello gem yesterday and will make a video later today to show how they can be used. I'll make sure to put a link to the video in this issue when it's done.

I forked your app and added the new slack_trello commands: https://github.com/MrPowers/slack-trello/commit/c62e03c4ea8950d8fba8e416cb511fa2a1fbf6f0. I didn't submit a pull request because I don't know if it will work. In the before do block you're using a request variable and in the #work method you're using params - I'm guessing one of those needs to be changed?

I definitely think you should pursue the Sinatra option and I am happy to help anytime. Thanks! :smile_cat:

codelitt commented 9 years ago

Thanks!

Commands look great. Thanks a lot for integrating them.

You're correct about the before do block. It's not properly working. I was focused on getting the general app working, and haven't had time to fix it. I just checked the documentation for Sinatra and it's actually easier than I was making it.

I'll pull your fork, make the needed changes to that block, and then merge your additions into mine. Thanks for the help! It's a handy project!

codelitt commented 9 years ago

FYI: This is how the block should look. https://github.com/codelittinc/slack-trello/blob/develop/slack_trello.rb#L11-L13

MrPowers commented 9 years ago

Great, I added your Sinatra app to the README.

I also made a video of the commands in action: https://www.youtube.com/watch?v=LNbVptbUjBk&feature=youtu.be

Feel free to submit a pull request to the slack-trello gem if you have any ideas for other commands. Let me know when you get the Sinatra app deployed in production. Once it's production-ready, I will try to deploy it too. Thanks!

codelitt commented 9 years ago

Awesome! Thanks! I also saw you mentioned it in the video. Great new commands. I incorporated them.

My repo should be ready to deploy. Let me know if you have any issues. I also updated my readme to give people more info about where this comes from

https://github.com/codelittinc/slack-trello

I'll keep my eye out for any other commands that would be useful and will contribute when I have something.

codelitt commented 9 years ago

@MrPowers just in case you didn't see this message ^.

Keep me posted if new commands come in. Great work!