medizininformatik-initiative / feasibility-backend

Backend of the feasibility-gui.
Apache License 2.0
2 stars 5 forks source link

#199 - Save and load query results for saved queries #204

Closed michael-82 closed 8 months ago

michael-82 commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Merging #204 (4eb5e27) into develop (7cf36f1) will increase coverage by 2.23%. The diff coverage is 83.58%.

@@              Coverage Diff              @@
##             develop     #204      +/-   ##
=============================================
+ Coverage      71.12%   73.35%   +2.23%     
- Complexity       481      508      +27     
=============================================
  Files            123      124       +1     
  Lines           2116     2177      +61     
  Branches          98      103       +5     
=============================================
+ Hits            1505     1597      +92     
+ Misses           551      520      -31     
  Partials          60       60              
Files Coverage Δ
...sibility_gui_backend/query/api/QueryListEntry.java 100.00% <ø> (ø)
.../feasibility_gui_backend/query/api/SavedQuery.java 100.00% <ø> (ø)
...gui_backend/query/api/status/FeasibilityIssue.java 80.00% <100.00%> (+0.51%) :arrow_up:
..._gui_backend/query/api/status/SavedQuerySlots.java 100.00% <100.00%> (ø)
...asibility_gui_backend/query/persistence/Query.java 83.33% <ø> (+16.66%) :arrow_up:
...lity_gui_backend/query/persistence/SavedQuery.java 66.66% <100.00%> (+50.00%) :arrow_up:
...i_backend/query/v3/QueryHandlerRestController.java 85.97% <92.85%> (+1.84%) :arrow_up:
...ibility_gui_backend/query/QueryHandlerService.java 78.30% <60.00%> (+39.92%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

juliangruendner commented 9 months ago

@michael-82 To additional functions are missing from the implementation:

  1. IS: When reading a saved query it does not include the comment. SHOULD: If a query is a saved query it should include the comment.

  2. IS: It should be possible for a user to UPDATE a saved query. When updating a saved query it should only be possible to change the name and comment, but not the query itself