search

medizininformatik-initiative / kerndatensatzmodul-mikrobiologie

1 stars 0 forks source link

Wrong URL for SNOMED CT in several VS #7

Closed jpwiedekopf closed 9 months ago

jpwiedekopf commented 10 months ago

In several VS, the canonical URL for SNOMED CT is not correct. It SHOULD always be "http://snomed.info/sct":

Filename Name wrong URL
MII_VS_Mikrobio_Detection.json "MII_VS_Mikrobio_Qualitative_Labor_Ergebnisse_SNOMED" http://snomed.org
Morphologie.json "MII_VS_Mikrobio_Morphologie_SNOMEDCT" http://snomed.org
MII_VS_Mikrobio_voraussichtliche_Resistenz.json "MII_VS_Mikrobio_voraussichtliche_Empfindlichkeit_SNOMED" http://snomed.org
MRE.json "MII_VS_Mikrobio_MRE_Klasse_SNOMEDCT" http://snomed.org
Mikrskopie_methode.json "MII_VS_Mikrobiologie_Mikroskopiemethoden_SNOMEDCT" shttp://snomed.org
rinaldie commented 9 months ago

I think you switched he two URLs them and intended that i should replace the URL http://snomed.info/sct with http://http://snomed.org in those files, which I idid.

jpwiedekopf commented 9 months ago

No, sorry. The correct URL for SNOMED CT is http://snomed.info/sct, as per the FHIR specification.

All ValueSets that use SNOMED CT, and profiles with patterns, need to be consistently changed. Please change the resources on Simplifier, and feel free to assign me so I can be your second set of eyes :)

rinaldie commented 9 months ago

That is funny... I think i had misunderstood the slide on TMF sharepoint and changed them all to http://snomed.org.

Oh well... they should all now be http://snomed.info/sct

jpwiedekopf commented 9 months ago

Looks (almost) good to me! The only missing change seems to be in the IG (guides/medizininformatikinitiative-modulmikrobio-implementationguide/IG-MII-Modul-Mikrobiologie/Technische-Implementierung/Terminologien.page.md and guides/medizininformatikinitiative-modulmikrobio-implementationguide/IG-MII-Modul-Mikrobiologie/Technische-Implementierung/Terminologien.page.md), where http://snomed.org is still present.

jpwiedekopf commented 9 months ago

In mii-vs-mikrobio-mikroskopiemethoden-snomedct.json, there is still a "system": "shttp://snomed.info/sct" in line 55 (rg "shttp" in the terminal with the awesome ripgrep tool).

rinaldie commented 9 months ago

Thanks, replaced!

rinaldie commented 9 months ago

Looks (almost) good to me! The only missing change seems to be in the IG (guides/medizininformatikinitiative-modulmikrobio-implementationguide/IG-MII-Modul-Mikrobiologie/Technische-Implementierung/Terminologien.page.md and guides/medizininformatikinitiative-modulmikrobio-implementationguide/IG-MII-Modul-Mikrobiologie/Technische-Implementierung/Terminologien.page.md), where http://snomed.org is still present.

thanks, this should also have been fixed both in DE and EN