medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

refactor: use `Logo` prop types for `MedlySidenavHeader` prop types #703

Closed gmukul01 closed 1 year ago

gmukul01 commented 1 year ago

affects: @medly-components/layout

PR Checklist

Description

use Logo prop types for MedlySidenavHeader prop types

Type of change

What is the current behaviour?

The types are different for MedlySidenavHeader which is eventually being passed to the Logo component

What is the new behaviour?

use Logo prop types for MedlySidenavHeader prop types

Does this PR introduce a breaking change?

Checklist

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 854f0233c66183838a5d612fa7da0f933e074db5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 1 target - [`lerna run lint`](https://cloud.nx.app/runs/rqqvrmcXob)

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6135191af558afdf95a116957a352de4bdf09787. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 5 targets - [`lerna run build`](https://cloud.nx.app/runs/2Bg1YcjmmB) - [`lerna run lint`](https://cloud.nx.app/runs/QicnQXCTAr) - [`lerna run build`](https://cloud.nx.app/runs/kudW9MvgLL) - [`lerna run lint`](https://cloud.nx.app/runs/spfCAKfBkd) - [`lerna run lint`](https://cloud.nx.app/runs/rqqvrmcXob)

Sent with πŸ’Œ from NxCloud.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication