Closed gmukul01 closed 1 year ago
CI is running/has finished running commands for commit 854f0233c66183838a5d612fa7da0f933e074db5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
π See all runs for this branch
Sent with π from NxCloud.
CI is running/has finished running commands for commit 6135191af558afdf95a116957a352de4bdf09787. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
π See all runs for this branch
Sent with π from NxCloud.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
affects: @medly-components/layout
PR Checklist
Description
use
Logo
prop types forMedlySidenavHeader
prop typesType of change
What is the current behaviour?
The types are different for
MedlySidenavHeader
which is eventually being passed to theLogo
componentWhat is the new behaviour?
use
Logo
prop types forMedlySidenavHeader
prop typesDoes this PR introduce a breaking change?
Checklist
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules