medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

fix: set overflow visible when accordion is visible #706

Closed gmukul01 closed 1 year ago

gmukul01 commented 1 year ago

affects: @medly-components/core

PR Checklist

Description

Set overflow visible to Accordion.Content component when accordion is visible so that if that renders any popup that can be visible

Type of change

How has this been tested?

(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)

[ ] Test A

[ ] Test B

Fixes #

What is the current behaviour?

Accordion.Content is by default overflow hidden and because of that any pop up like datepicker is not visible

What is the new behaviour?

Overflow is set to visible for Accordion.Content component when accordion is visible so that any pop up inside the content can be visible

Does this PR introduce a breaking change?

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

sonarcloud[bot] commented 1 year ago

Please retry analysis of this Pull-Request directly on SonarCloud.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 26517339967f3042219cf9e7c596fa7623d37126. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`lerna run build`](https://cloud.nx.app/runs/Xe9gOcTJnM) - [`lerna run lint`](https://cloud.nx.app/runs/r5a6J1ffTb) - [`lerna run build`](https://cloud.nx.app/runs/dFO0GKQwsY) - [`lerna run lint`](https://cloud.nx.app/runs/rsu9uAuxWr)

Sent with 💌 from NxCloud.