medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

fix: fix closing any popup like calendar in drawer component #710

Closed gmukul01 closed 1 year ago

gmukul01 commented 1 year ago

affects: @medly-components/core

PR Checklist

Description

Any popup like Calendar or SingleSelct popup is not closing on clicking outside of popup but inside Drawer component. Because the eventPropagation was stopped in Drawer component and beacuse of that those popup are not closing.

Type of change

How has this been tested?

(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)

[ ] Test A

[ ] Test B

Fixes #

What is the current behaviour?

Any popup like Calendar or SingleSelct popup is not closing on clicking outside of popup but inside Drawer component.

What is the new behaviour?

Now popup like Calendar or SingleSelct popup is closing on clicking outside of popup but inside Drawer component.

Does this PR introduce a breaking change?

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c5385a35dbf6060bb3230e41a1f1e1b1c958032e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`lerna run build`](https://cloud.nx.app/runs/QxCY2OifQ4) - [`lerna run lint`](https://cloud.nx.app/runs/t149DjHHhd)

Sent with 💌 from NxCloud.