medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

fix: stop passing placeholder to wrapper component in multiselect component #711

Closed gmukul01 closed 1 year ago

gmukul01 commented 1 year ago

affects: @medly-components/core, @medly-components/forms

PR Checklist

Description

Stop passing placeholder prop to Wrapper component in MultiSelect component.

Type of change

How has this been tested?

(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)

[ ] Test A

[ ] Test B

Fixes #

What is the current behaviour?

Placeholder prop is by mistakenly passed to Wrapper component.

What is the new behaviour?

Placeholder prop is now not being passed to Wrapper component.

Does this PR introduce a breaking change?

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 75a016e20b7c75d39279b60938e5bfab8597cf0c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`lerna run build`](https://cloud.nx.app/runs/kMMbs63KwV) - [`lerna run lint`](https://cloud.nx.app/runs/gBH2TEIvhT)

Sent with 💌 from NxCloud.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication