medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

feat: update useSWRAxios return type #715

Closed gmukul01 closed 1 year ago

gmukul01 commented 1 year ago

affects: @medly-components/utils

PR Checklist

Description

It includes below changes:

  1. Update the Data return type when we pass fallbackData
  2. The response will be updated when the error occurs with error response.
  3. The error will now have the error data instead of the whole axios error response.

Type of change

How has this been tested?

(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)

[ ] Test A

[ ] Test B

Fixes #

What is the current behaviour?

(Replace This Text: Please describe the current behaviour you are modifying, or link a relevant issue.)

What is the new behaviour?

(Replace This Text: Please describe the expected new behaviour.)

Does this PR introduce a breaking change?

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b30a10215aed7821edffb99e5b1ce66cd4507e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`lerna run build`](https://cloud.nx.app/runs/BrQAnYKrxB) - [`lerna run lint`](https://cloud.nx.app/runs/T62bjkKj1y)

Sent with 💌 from NxCloud.