Closed Bhusnar5044 closed 1 year ago
CI is running/has finished running commands for commit 5d990f213c1bde4f7fe665d76d87785bdfa5a99a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
Sent with 💌 from NxCloud.
@Bhusnar5044 I am merging this PR to unblock you, but could you please raise another PR to remove the duplicate code.
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
86.5% Duplication
@Bhusnar5044 I am merging this PR to unblock you, but could you please raise another PR to remove the duplicate code.
@gmukul01 sonarCloud showing duplications in the test file, it's showing duplications for lines. not sure how to fix it.
@Bhusnar5044 Actually we have to extract out the common lines which selects one of the option in the SingleSelect. For example below lines are common accross all the tests.
fireEvent.focus(screen.getByRole('textbox'));
fireEvent.keyDown(container, { key: 'ArrowDown', code: 40 });
fireEvent.keyDown(container, { key: 'Enter', code: 13 });
PR Checklist
Description
This PR fixes issue #720
Type of change
How has this been tested?
(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)
[ ] Test A
[ ] Test B
Fixes #720
What is the current behaviour?
the focus stays on the field when user select option and click outside the single select field
What is the new behaviour?
removed focus on the field when we user selects option and click outside the single select field
Does this PR introduce a breaking change?
Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)
Additional context
(Replace This Text: Please describe any other related information or add screenshots of the PR.)
Checklist
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules