medly / medly-components

🧩 Medly components provides numerous themable react components, each with multiple varitaions of sizes, colors, position etc.
https://medly.github.io/medly-components/
MIT License
79 stars 54 forks source link

fix(core): pass HTML autoComplete attribute to input elements in DateRangePicker #724

Closed Abg4real closed 1 year ago

Abg4real commented 1 year ago

affects: @medly-components/core

ISSUES CLOSED: #723

PR Checklist

Description

This PR fixes the issue #723

Type of change

Fixes #723

What is the current behaviour?

Default input attributes were not being passed to input elements

What is the new behaviour?

Default input attributes are being passed to input elements

Does this PR introduce a breaking change?

Checklist

gmukul01 commented 1 year ago

@Abg4real If we spread restProps to all three elements OuterWrapper, and two Input elements then the common props like classname would be applied to all three elements. I would suggest we can be more specific over here and extract out the common input props which you require and apply them to input elements.

Abg4real commented 1 year ago

@gmukul01 Okay. I was facing issue with autoComplete attribute, so I will only add that to input element.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 925920ac3c9c3ceab7ce9f3f3429e94d63c51d42. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`lerna run build`](https://cloud.nx.app/runs/mZoqck5n7o) - [`lerna run lint`](https://cloud.nx.app/runs/LYWN9pMRl9)

Sent with 💌 from NxCloud.