Closed Abg4real closed 1 year ago
@Abg4real If we spread restProps to all three elements OuterWrapper
, and two Input elements then the common props like classname would be applied to all three elements. I would suggest we can be more specific over here and extract out the common input props which you require and apply them to input elements.
@gmukul01 Okay. I was facing issue with autoComplete attribute, so I will only add that to input element.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
CI is running/has finished running commands for commit 925920ac3c9c3ceab7ce9f3f3429e94d63c51d42. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
Sent with 💌 from NxCloud.
affects: @medly-components/core
ISSUES CLOSED: #723
PR Checklist
Description
This PR fixes the issue #723
Type of change
Fixes #723
What is the current behaviour?
Default input attributes were not being passed to input elements
What is the new behaviour?
Default input attributes are being passed to input elements
Does this PR introduce a breaking change?
Checklist
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules