Closed Bhusnar5044 closed 1 year ago
CI is running/has finished running commands for commit 91c600529dcf8bde7b795fbaf892a4ea14e1f90d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
Sent with 💌 from NxCloud.
@Bhusnar5044 Values should always be unique hence we can remove adding the index as key. This should also remove the sonar error.
@Bhusnar5044 Values should always be unique hence we can remove adding the index as key. This should also remove the sonar error.
done :+1:
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
affects: @medly-components/core
ISSUES CLOSED: #732
PR Checklist
Description
singleSelect - search filter not showing the filtered options, If there is any duplicate option available with a different value, the search not showing those options.
Type of change
Fixes #732
What is the current behaviour?
Search not filtering the options if it contains duplicate label option.
What is the new behaviour?
Search shows the filtered options even if there are any duplicate options with the same label.
Does this PR introduce a breaking change?
Checklist
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules