gmukul01 commented 10 months ago

affects: @medly-components/core, @medly-components/forms, @medly-components/theme

BREAKING CHANGE: textfield theme needs to be updated to include the icon theme

Description

Extract the icon colors as separate colors in TextField component.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes and API changes)
[ ] Build changes
[ ] CI changes
[ ] Document content changes
[ ] Performance improvement
[ ] Add missing tests
[ ] Others (please describe)

How has this been tested?

Updated the existing unit test cases.

Fixes #

What is the current behaviour?

Right now we are using label color for icon color

What is the new behaviour?

Add new values in the theme to color the icon in textField component.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

nx-cloud[bot] commented 10 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6c843ec0ea5ef9115cff180b30799e4a008ded9e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

- [`lerna run test --stream --parallel --since=origin/master`](https://cloud.nx.app/runs/WLRR3J8fUo?utm_source=pull-request&utm_medium=comment) - [`lerna run build`](https://cloud.nx.app/runs/AgoBvAFdlj?utm_source=pull-request&utm_medium=comment) - [`lerna run lint --stream --parallel --since=origin/master`](https://cloud.nx.app/runs/dXH0MXZ3va?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.