search

medooze / media-server-node

WebRTC Media Server for Node.js
MIT License
802 stars 119 forks source link

Use share pointer for PlayerFacade and Player.js #211

Closed ZitaLiao closed 1 year ago

ZitaLiao commented 1 year ago

@murillo128 Do I need to include src/media-server_wrap.cxx in PR as well? There are other un-related space/line-length difference even though I used the same swig version (4.1.0)

murillo128 commented 1 year ago

Can you make the change for audio as well? I will run swig after merging to avoid the whitespace changes

murillo128 commented 1 year ago

@ZitaLiao ptal

Can you make the change for audio as well? I will run swig after merging to avoid the whitespace changes

ZitaLiao commented 1 year ago

@ZitaLiao ptal

Can you make the change for audio as well? I will run swig after merging to avoid the whitespace changes

@murillo128 added the audio as well. I compiled with swig on my env. Please check.