medooze / media-server-node

WebRTC Media Server for Node.js
MIT License
796 stars 119 forks source link

prevent "not dumping" C++ errors #233

Closed mildsunrise closed 9 months ago

mildsunrise commented 9 months ago

calling transport.dump() and then transport.stopDump() currently causes C++ to print a "not dumping" error if only BWE was requested in the call to dump():

[61519 VIEW4     ][1701274443.460][ERR]-DTLSICETransport::StopDump() | Not dumping

this is currently spamming our logs a bit. so, have Transport track state and avoid unnecessary C++ calls.

an alternative is to remove the C++ Error() log line.