Open mildsunrise opened 9 months ago
(rebased)
is this ready for review?
it is missing a relatively small change for it to compile without RTTI. sorry, I'll push that change tomorrow. for all other intents and purposes, this can be considered ready to review yes
I think we should add exceptions to bitstream readers/writters before merging this PR as I think we can simplify the code a lot once the exceptions are included.
Please review #252 first, as it's a dependency for this PR.
Extends
H264SeqParameterSet
to parse the full descriptor (right now it's not parsing the VUI).I've basically adapted the code from nal-extractor: https://github.com/medooze/nal-extractor/blob/main/lib/SPS.ts https://github.com/medooze/nal-extractor/blob/main/test/SPS.test.ts
output for:
is:
For some reason
time_scale
says 61 rather than 60. I'll investigate later.