search

medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

make tokens optional #1

Closed theRealWardo closed 2 years ago

theRealWardo commented 2 years ago

the spec says auth MAY be implemented so let's ensure that the test client support no auth being implemented on the server.

murillo128 commented 2 years ago

Thank you for the PR! I have added support for optional tokens in https://github.com/medooze/whip-js/commit/c879b1add161c2219c159ec6267126e2eb0206fb better.

theRealWardo commented 2 years ago

thanks @murillo128 ! I do think the signature of publish should still change so that it can more easily and beautifully be called by devs not using token auth. what do you think about that?

- whip.publish(url, token, pc);
+ whip.publish(pc, url, token);
murillo128 commented 2 years ago

lgtm

El lun, 13 sept 2021 a las 17:14, Matt Ward @.***>) escribió:

thanks @murillo128 https://github.com/murillo128 ! I do think the signature of publish should still change so that it can more easily and beautifully be called by devs not using token auth. what do you think about that?

  • whip.publish(url, token, pc);
  • whip.publish(pc, url, token);

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/medooze/whip-js/pull/1#issuecomment-918295645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFN42W4A4X4VXMC6TO2DTUBYIMBANCNFSM5D4NC74Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.