search

medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

Whep dont quit 405 501 #10

Closed cameronelliott closed 11 months ago

cameronelliott commented 11 months ago

In my testing with a whep clients that pre-gathers ice candidates, and a resource which doesn't handle PATCH, the existing code will throw and give up a whep session attempt. (When returning a 501 status)

This small tweak allows a whep session to still work on 501 and 405 cases. which I think is justified given the text in draft-murillo-whep-02.txt

Please let me know your thoughts.

...

   The SDP provided by the WHEP Player MAY be sent after the full ICE
   gathering is complete with the full list of ICE candidates, or it MAY
   only contain local candidates (or even an empty list of candidates)
   as per [RFC8863].

...

   If the WHEP resource supports either Trickle ICE or ICE restarts, but
   not both, it MUST return a "405 Not Implemented" response for the
   HTTP PATCH requests that are not supported.

   If the WHEP resource does not support the PATCH method for any
   purpose, it MUST return a "501 Not Implemented" response, as
   described in [RFC9110] section 6.6.2.