medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
67 stars 16 forks source link

CR's on some lines in the codebase, standardize on LF ? #14

Closed cameronelliott closed 10 months ago

cameronelliott commented 1 year ago

I discovered when trying to do some work the codebase has CR's on some lines (not all) have CR's on them (about 47 lines out of 493 in whep.js)

Can we remove these, and define a line ending to be used?

Github seems to recommend some git settings on Windows where CRLF -> LF: link here

Also, please let me know if you want issues/PRs for this repo. I don't want to be bothering you if you're not into this. I have a set of commits for typescript types, and fixing some package.json bugs, and moving towards a conformant ESM package. But I don't want to be submitting this stuff if you are not interested. So your thoughts are appeciated.

murillo128 commented 10 months ago

linted files