search

medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
67 stars 16 forks source link

Trickle ICE If-Match header #22

Closed rgl closed 10 months ago

rgl commented 1 year ago

This repository WHEP client Trickle ICE implementation does not work with the https://github.com/bluenviron/mediamtx WHEP server, due to a missing If-Match header. This header is required, accordingly to https://www.ietf.org/archive/id/draft-murillo-whep-02.html#name-ice-and-nat-support, which states:

A WHEP player sending a PATCH request for performing trickle ICE MUST include an "If-Match" header field with the latest known entity-tag as per [RFC9110] section 3.1. When the PATCH request is received by the WHEP resource, it MUST compare the indicated entity-tag value with the current entity-tag of the resource as per [RFC9110] section 3.1 and return a "412 Precondition Failed" response if they do not match.

Can you please clarify?

murillo128 commented 10 months ago

Etag and If-match support has been added in latest 1.1.0

https://github.com/medooze/whip-whep-js/commit/708320468e8afc114ce0434ebab70b0dede10340