search

medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

trickle is not a function #26

Closed Fauny closed 3 months ago

Fauny commented 6 months ago

simple whep test with srs docker.

I'd not change the whep example in README page except url, error in console:

Uncaught TypeError: this.trickle is not a function
    at whep.js:240:50

when i just change the line, it works, but autoplay did not work, play button click is needed. safari cannot show anyhow.

this.iceTrickeTimeout = 1 // setTimeout(() => this.trickle(), 0);
a-wing commented 6 months ago

I found this problem too, This lib no have function trickle()

a-wing commented 3 months ago

This commit rename trickle() => patch() https://github.com/medooze/whip-whep-js/commit/708320468e8afc114ce0434ebab70b0dede10340

Fix this: https://github.com/binbat/whip-whep-js/commit/ac259e32f9e8dffd1ac9f5b49f4ab2d8bf2badb6

You can use npm i @binbat/whip-whep@1.1.1-sdp-trickle fix this problem