search

medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

ETag + If-Match support? #5

Closed cameronelliott closed 7 months ago

cameronelliott commented 1 year ago

The July 25 2022 draft says:

As the HTTP PATCH request sent by a WHIP client may be received out- of-order by the WHIP resource, the WHIP resource MUST generate a unique strong entity-tag identifying the ICE session as per [RFC9110] section 2.3. The initial value of the entity-tag identifying the initial ICE session MUST be returned in an ETag header field in the 201 response to the initial POST request to the WHIP endpoint.

Currently whip.js and whep.js do not grab the ETag header, and they do not pass it in inside the If-Match header, either.

Are you planning on adding this? Would you rather receive a PR?

Thanks. (And thank you for your WebRTC work in general, @murillo128 )

murillo128 commented 1 year ago

yes, please go ahead with a PR

murillo128 commented 7 months ago

added in latest version