medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

Fix missing port number in m= SDP fragments #6

Closed cameronelliott closed 1 year ago

cameronelliott commented 1 year ago

I think (sorry if I am wrong) the code to generate SDP fragments needs to also output port numbers for the m=audio/m=video lines.

The SDP RFC ABNF seems to require it, and as far as I can tell this is just a small bug in the code and WHIP draft.

murillo128 commented 1 year ago

thank you!