medooze / whip-whep-js

WHIP and WHEP clients javascript module
MIT License
65 stars 15 forks source link

Fix splitting of link header subitems #8

Closed redoPop closed 1 year ago

redoPop commented 1 year ago

This PR fixes the parsing of link header values that contain equals signs:

Before this change:

After this change:

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

redoPop commented 1 year ago

For context: I discovered this bug when it caused Twilio TURN server authentications to fail due to munged credentials, resulting in broken ICE for connections where relay was required. (The browser attempted to use server reflex candidates.)

redoPop commented 1 year ago

@murillo128 Understandable if it's not a priority, but after seeing 1.0.1 go out with a conflicting change I wanted to make sure this wee fix hadn't fallen under the radar! 🙂

murillo128 commented 1 year ago

i completely forgot about this, please rebase (if you haven't done so already) and i will merge it

redoPop commented 1 year ago

No prob! Rebase complete! Ran into another tiny bug today but opened a separate PR for that since it's unrelated.

murillo128 commented 1 year ago

thank you!