medspacy / QuickUMLS

System for Medical Concept Extraction
MIT License
3 stars 6 forks source link

replace quickumls_simstring with pysimstring #16

Closed jianlins closed 1 year ago

jianlins commented 1 year ago

To avoid libiconv dependency, which often an issue when install in windows. Reorganize the test cases. Make sure pytest passes.

burgersmoke commented 1 year ago

Before I merge this, I should make sure that all of our tests pass and that this can build and run successully on platforms like Windows since in the past @burgersmoke had to fix some Windows-only issues:

https://github.com/medspacy/medspacy/issues/223

burgersmoke commented 1 year ago

I wrote Issue #17 to address this. I will merge this change into a new branch to evaluate and test it there.

burgersmoke commented 1 year ago

Merged into "feature branch" for additional testing.