medspacy / QuickUMLS

System for Medical Concept Extraction
MIT License
3 stars 6 forks source link

GPL license for a package that is never imported #19

Open jdposada opened 7 months ago

jdposada commented 7 months ago

The unidecode package is mentioned on the requirements.txt. However, I did not find an import for it. Not sure what package requires it. My suggestion is to replace it with a package that has a friendlier license.

burgersmoke commented 6 months ago

We've been discussing this in our Slack channel, but here's a bit of context here that we can track since I followed up on this:

medspacy QuickUMLS still does use unidecode. An example of it is here:

https://github.com/medspacy/QuickUMLS/blob/master/quickumls/core.py

Specifically, it use used to optionally normalize unicode here:

https://github.com/medspacy/QuickUMLS/blob/fe5d999c21ff0da7564ed1812b090208e25372c1/quickumls/core.py#L305

Here's what the code looks like:

            if self.normalize_unicode_flag:
                ngram_normalized = unidecode(ngram_normalized)