search

medusa-project / book-tracker

Medusa Book Tracker
0 stars 0 forks source link

Add IAM role to Terraform scripts #53

Closed adolski closed 8 months ago

adolski commented 9 months ago

The Book Tracker's IAM role is not defined in the Book Tracker's Terraform scripts. We should make sure that it is defined there instead of making changes via the AWS web console.

gaurijo commented 8 months ago

Since the output of this didn't actually change anything, do I still need to run a terraform apply or is that just an extra step in this case?

adolski commented 8 months ago

I don't know if it's required or not, but I'd run it anyway. It couldn't hurt. I don't know enough about how Terraform works--t might update some kind of internal state

gaurijo commented 8 months ago

You're right, I think it does update or do something with theterraform.lock.hcl.

I ran an apply for the demo service, and just pushed up a PR for the same thing with prod service.

After that's merged I'll run an apply for prod and then I plan todeploy to demo and prodagain so everything is up to date (unless it's not needed since this was already added via aws console a few days ago)

gaurijo commented 8 months ago

Everything has been redeployed successfully and all branches (develop/demo/prod) are up to date now.