feat: use multistage builds

medusajs / docker-medusa

This repo is managed by the Medusa Community. Medusa does not provide official support for Docker, but we will accept fixes and documentation. Use at your own risk.

181 stars 87 forks source link

feat: use multistage builds #8

Closed fPolic closed 2 years ago

fPolic commented 2 years ago

What

reorganise Dockerfiles to use multistage build
optimise the size of (final) running containers
fix issues where unnecessary things were copied to the context
add .dockerignore files

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 513711ace7df34452dc327ed944e1a6806adfcc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Prn-Ice commented 2 years ago

I'm currently trying this out, I had a few issues.

The admin and storefront docker files are the same, even the working directory files, is this a mistake?
Without the RUN npm install -g gatsby-cli section on both the admin and storefront, both fail to start
In the docker-compose.dev.yml, the postgres service is defined without an image

Even after fixing these issues, I still cant get the storefront to start but I'm working on it.

pan-sveta commented 2 years ago

I would say that you miss as prod in the backend Dockerfile.

Otherwise, the production compose is failing for me.