search

medusajs / medusa

Building blocks for digital commerce
https://medusajs.com
MIT License
24.86k stars 2.48k forks source link

Incorrect currency symbol for INR #4629

Open sulabh opened 1 year ago

sulabh commented 1 year ago

Bug report

Describe the bug

The symbol_native variable for INR currency is incorrect.

System information

Medusa version (including plugins): 1.13.1 Node.js version: 20.0.5 Database: postgres Operating system: MacOs Ventura Browser (if relevant): All

Steps to reproduce the behavior

  1. Enable and Select INR as default currency.
  2. Go to Medusa Admin > Products > New Product > Variants > Porduct Variants > Pricing
  3. The placeholder for Price textbox is টকা which is incorrect for INR.

Expected behavior

The correct symbol for INR is ₹

Screenshots

Screenshot 2023-07-28 at 3 34 13 PM

Code snippets

@medusajs/admin-ui/ui/src/utils/currencies.ts @medusajs/medusa/utils/currencies.ts has this code

Screenshot 2023-07-28 at 3 44 41 PM

which is incorrect.

srindom commented 1 year ago

Would be happy to accept @pinakipb2's PR if reopened - alternatively if someone else is up for opening a PR we can merge that.

pinakipb2 commented 1 year ago

@srindom Fell free to review the PR #4831