Customer credit card charged when inventory is zero during order complete process

[Arsenalist]

Medusa: 1.14. Stripe Plugin: 6.0

Symptom: Customer credit card is charged even when inventory is zero during order complete process.

To reproduce, do the following:

• Create a Product with inventory 2
• Add 2 items to cart and start checkout
• Call stripe.confirmCardPayment()
• DO NOT CALL CART COMPLETE
• Go to backend and manually reduce inventory to 0 in database
• Now call cart complete

The following error is received on cart complete

{"code":"payment_intent_unexpected_state","type":"invalid_data","message":"An error occurred in cancelPayment:\nundefined\n"}

The Stripe error log has:

You cannot cancel this PaymentIntent because it has a status of succeeded.

This happens because cancelPayment() is being called on a "succeeded" payment. @chemicalkosek describes it best on Discord thread. Here is the exact line of code where it happens: https://github.com/medusajs/medusa/blob/c348263fdba73ad0cdb8b8941d91a415d5b26a2a/packages/medusa/src/strategies/cart-completion.ts#L373

The payment had a requires_capture status then it would succeed with the cancelation on Stripe. Because it's succeeded , it fails. I think this is a remnant from back when this was developed for uncaptured card payments.

Nowadays all those gateway payments are captured automatically in Stripe and you can't change that. It's a requirement to autocapture. Those payments are actually a majority in Poland. A little percentage of customers pay by card.

Some possible solutions:

1. Check that payment status is not succeeded before trying to cancel payment
2. Return a different entity indicating the issue so customer can be presented with something better

[Arsenalist]

Hi - any update on this? This happened again and it's causing me chaos. Basically:

• Inventory was available
• Customer was charged using stripe.confirmCardPayment
• Inventory went down to 0 during this time
• Order complete process started but failed as inventory was 0 and it tried to cancel payment

[alessioacella]

+1