Gift card being applied inconsistently in cart and order

[Arsenalist]

To reproduce:

• set gift_card_taxable to false in regions table
• create gift card
• apply gift card to a product which has taxes and shipping
• place order
• expected: order.gift_card_total === cart.gift_card_total
• actual: order.gift_card_total !== cart.gift_card_total

Discord Link: https://discord.com/channels/876835651130097704/1150475042669465692

Medusa version (including plugins): 1..14 Node.js version: 16

Cart screen

Order screen

Stripe is getting charged

Database: Postgres 12 Operating system: Linux

This piece of code in cart.ts decorateTotals() does not check if region has gift card taxable when calculating gift cardable amount:

    const giftCardTotal = await this.newTotalsService_.getGiftCardTotals(
      cart.subtotal - cart.discount_total,
      {
        region: cart.region,
        giftCards: cart.gift_cards,
      }
    )

While this one in order.ts createFromCart() does:

      const giftCardableAmount =
        (cart.region?.gift_cards_taxable
          ? cart.subtotal! - cart.discount_total!
          : cart.total! + cart.gift_card_total!) || 0 // we re add the gift card total to compensate the fact that the decorate total already removed this amount from the total

I also don't think this is correct decorateTotals() is correct since gift card applies to whole amount in the cart, not just subtotal-discount_total. I mentioned that in Discord as well.

[Arsenalist]

Submitted this: https://github.com/medusajs/medusa/pull/5015

[adrien2p]

@olivermrbl mentionning you here so that you have the full context of the origin of the pr

[Arsenalist]

For the record, I believe the correct behaviour is for the gift card to cover everything (sub total, tax, shipping). So Stripe should not be getting charged at all if gift card is worth like $40