medusajs / medusa

Building blocks for digital commerce
https://medusajs.com
MIT License
24.34k stars 2.38k forks source link

Docs(Code Issue): Code Issue in /plugins/notifications/sendgrid #7068

Open riivostolts opened 4 months ago

riivostolts commented 4 months ago

Preliminary Checks

Issue Summary

There is a wrong key shown in the docs for "Order Shipment Created" template. order_shipped_template does not pass the condition in sendgrid.js's getTemplateId function.

How can this issue be resolved?

  1. order_shipped_template should be renamed to order_shipment_created_template

Are you interested in working on this issue?

shahednasser commented 4 months ago

Nice catch! Seems like it's a bug in the sendgrid plugin, where if the template is passed in the plugin's options without a locale, it looks for order_shipment_created_template, whereas in the localized options, it looks for order_shipped_template.

Will report it and add a temporary note in the docs