search

medusajs / medusa

Building blocks for digital commerce
https://medusajs.com
MIT License
24.45k stars 2.4k forks source link

Incorrect Popover z-index in Edit Variant modal #8158

Closed Dominic-Preap closed 1 month ago

Dominic-Preap commented 1 month ago

Bug report

Describe the bug

Popover of Edit Variant is behind number input.

System information

Medusa version (including plugins): @medusajs/admin": "^7.1.14" Node.js version: 20.9.0 Database: Postgresql Operating system: Windows 10 Browser (if relevant): Chrome

Steps to reproduce the behavior

  1. Go to Product detail
  2. Click Edit Variant in Variant section
  3. Click '...' for Edit Variant to see

Expected behavior

Popover should be in front of input.

Screenshots

image

Code snippets

N/A

Additional context

N/A

srindom commented 1 month ago

Thanks for opening this issue @Dominic-Preap - would you be up for working on a PR to fix this?

Dominic-Preap commented 1 month ago

@srindom sure, I'll check contribution guide and make a PR.

srindom commented 1 month ago

@Dominic-Preap - how did it go with getting started on this? Happy to help if you are bumping into challenges?

Dominic-Preap commented 1 month ago

I'm so sorry, I've been busy lately 😔

On Mon, Jul 22, 2024, 4:25 PM Sebastian Rindom @.***> wrote:

@Dominic-Preap https://github.com/Dominic-Preap - any luck?

— Reply to this email directly, view it on GitHub https://github.com/medusajs/medusa/issues/8158#issuecomment-2242498854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ5Z6RZT3SOEPY3OMNJ4RLZNTF2DAVCNFSM6AAAAABLAAQG4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSGQ4TQOBVGQ . You are receiving this because you were mentioned.Message ID: @.***>

adevinwild commented 1 month ago

Hey! I had a little bit of time to fix it, It should be ok now 🙌

kasperkristensen commented 1 month ago

Fixed by @adevinwild in #8358